From fbaf0bb26397aa498eb9156f06d5a6fe34dd7dd8 Mon Sep 17 00:00:00 2001 From: Daniel Baumann Date: Fri, 19 Apr 2024 03:14:29 +0200 Subject: Merging upstream version 125.0.1. Signed-off-by: Daniel Baumann --- js/loader/ModuleLoaderBase.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'js/loader/ModuleLoaderBase.cpp') diff --git a/js/loader/ModuleLoaderBase.cpp b/js/loader/ModuleLoaderBase.cpp index 59e77b2d9c..228c96ad69 100644 --- a/js/loader/ModuleLoaderBase.cpp +++ b/js/loader/ModuleLoaderBase.cpp @@ -969,7 +969,12 @@ void ModuleLoaderBase::FinishDynamicImport( LOG(("ScriptLoadRequest (%p): Finish dynamic import %x %d", aRequest, unsigned(aResult), JS_IsExceptionPending(aCx))); - MOZ_ASSERT(GetCurrentModuleLoader(aCx) == aRequest->mLoader); + MOZ_ASSERT_IF(NS_SUCCEEDED(aResult), + GetCurrentModuleLoader(aCx) == aRequest->mLoader); + // For failure case, aRequest may have already been unlinked by CC. + MOZ_ASSERT_IF( + NS_FAILED(aResult), + GetCurrentModuleLoader(aCx) == aRequest->mLoader || !aRequest->mLoader); // If aResult is a failed result, we don't have an EvaluationPromise. If it // succeeded, evaluationPromise may still be null, but in this case it will @@ -1057,7 +1062,8 @@ bool ModuleLoaderBase::HasPendingDynamicImports() const { void ModuleLoaderBase::CancelDynamicImport(ModuleLoadRequest* aRequest, nsresult aResult) { - MOZ_ASSERT(aRequest->mLoader == this); + // aRequest may have already been unlinked by CC. + MOZ_ASSERT(aRequest->mLoader == this || !aRequest->mLoader); RefPtr req = mDynamicImportRequests.Steal(aRequest); if (!aRequest->IsCanceled()) { -- cgit v1.2.3