2 files changed, 112 insertions, 0 deletions
diff --git a/t/cppcheck.t b/t/cppcheck.t
new file mode 100644
index 0000000..9e8108a
--- /dev/null
+++ b/t/cppcheck.t
@@ -0,0 +1,49 @@
+#!/usr/bin/perl
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+use strict;
+use warnings;
+
+use Test::More;
+use Test::Dpkg qw(:needs);
+
+test_needs_author();
+test_needs_command('cppcheck');
+test_needs_srcdir_switch();
+
+plan tests => 1;
+
+# XXX: We should add the following to @cppcheck_opts, but then cppcheck emits
+# tons of false positives due to not understanding non-returning functions.
+#  -DLIBDPKG_VOLATILE_API=1
+#  -Ilib
+my @cppcheck_opts = (qw(
+  -q --force --error-exitcode=2
+  --suppressions-list=t/cppcheck/cppcheck.supp
+), (
+  '--enable=warning,performance,portability,style',
+  '--template=\'{file}:{line}: {severity} ({id}): {message}\''
+));
+my $tags = qx(cppcheck @cppcheck_opts . 2>&1);
+
+# Fixup the output:
+chomp $tags;
+
+my $ok = length $tags == 0;
+
+ok($ok, 'cppcheck');
+if (not $ok) {
+    diag($tags);
+}
diff --git a/t/cppcheck/cppcheck.supp b/t/cppcheck/cppcheck.supp
new file mode 100644
index 0000000..fbe17dd
--- /dev/null
+++ b/t/cppcheck/cppcheck.supp
@@ -0,0 +1,63 @@
+//
+// Suppression file for cppcheck.
+///
+
+// We assume that the system has a sane NULL definition.
+varFuncNullUB
+
+// TODO: While perhaps valid there are many to handle right away.
+variableScope
+
+// Ignore, this is an imported module.
+unusedStructMember:lib/compat/obstack.c
+nullPointerArithmetic:lib/compat/obstack.c
+nullPointerRedundantCheck:lib/compat/obstack.c
+nullPointerArithmeticRedundantCheck:lib/compat/obstack.c
+
+// Ignore, we are testing the functions.
+knownConditionTrueFalse:lib/dpkg/t/t-macros.c
+
+// Ignore, we use our own test assertions macros.
+literalWithCharPtrCompare:lib/dpkg/t/t-test.c
+
+// Ignore, the code is used only for its binary artifacts.
+uninitMemberVar:*/Dpkg_Shlibs/patterns.cpp
+
+// BUG: False positive, it gets triggered even with -Ilib.
+unknownMacro
+
+// BUG: False positive, the function returns a pointer within a local.
+returnDanglingLifetime:lib/dpkg/pkg-hash.c
+
+// BUG: False positive, the variable uses operator() which writes to it.
+constVariable:dselect/pkgsublist.cc:111
+
+// BUG: False positive.
+syntaxError:lib/dpkg/t/*.c
+
+// BUG: False positive, the loop does an early exit.
+identicalInnerCondition:lib/dpkg/fsys-hash.c:96
+
+// BUG: False positive, the macros from lib/dpkg/dlist.h use the tail member.
+unusedStructMember:lib/dpkg/triglib.c:378
+
+// BUG: False positive, does not understand non-returning functors.
+negativeIndex:dpkg-deb/build.c
+nullPointerArithmeticRedundantCheck:lib/dpkg/db-fsys-files.c
+nullPointerArithmeticRedundantCheck:lib/dpkg/db-fsys-override.c
+nullPointerRedundantCheck:dpkg-deb/build.c
+nullPointerRedundantCheck:lib/dpkg/db-fsys-override.c
+nullPointerRedundantCheck:lib/dpkg/ehandle.c
+nullPointerRedundantCheck:src/enquiry.c
+nullPointerRedundantCheck:src/unpack.c
+nullPointerRedundantCheck:utils/update-alternatives.c:1193
+doubleFree:utils/update-alternatives.c:1248
+
+// BUG: False positive, does not understand non-returning functions + vaargs.
+va_end_missing:lib/dpkg/parsehelp.c:68
+
+// BUG: False positive, due to our local va_copy().
+va_list_usedBeforeStarted:lib/compat/vasprintf.c
+
+// BUG: False positive, SIGWINCH is not a fatal signal.
+unreachableCode:dselect/basecmds.cc:130