diff options
Diffstat (limited to '')
| -rw-r--r-- | t/cppcheck.t | 45 | ||||
| -rw-r--r-- | t/cppcheck/cppcheck.supp | 54 |
2 files changed, 99 insertions, 0 deletions
diff --git a/t/cppcheck.t b/t/cppcheck.t new file mode 100644 index 0000000..696b6b0 --- /dev/null +++ b/t/cppcheck.t @@ -0,0 +1,45 @@ +#!/usr/bin/perl +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <https://www.gnu.org/licenses/>. + +use strict; +use warnings; + +use Test::More; +use Test::Dpkg qw(:needs); + +test_needs_author(); +test_needs_command('cppcheck'); +test_needs_srcdir_switch(); + +plan tests => 1; + +my @cppcheck_opts = (qw( + -q --force --error-exitcode=2 + --suppressions-list=t/cppcheck/cppcheck.supp +), ( + '--enable=warning,performance,portability,style', + '--template=\'{file}:{line}: {severity} ({id}): {message}\'' +)); +my $tags = qx(cppcheck @cppcheck_opts . 2>&1); + +# Fixup the output: +chomp $tags; + +my $ok = length $tags == 0; + +ok($ok, 'cppcheck'); +if (not $ok) { + diag($tags); +} diff --git a/t/cppcheck/cppcheck.supp b/t/cppcheck/cppcheck.supp new file mode 100644 index 0000000..6dcb193 --- /dev/null +++ b/t/cppcheck/cppcheck.supp @@ -0,0 +1,54 @@ +// +// Suppression file for cppcheck. +/// + +// We assume that the system has a sane NULL definition. +varFuncNullUB + +// TODO: While perhaps valid there are many to handle right away. +variableScope + +// Ignore, this is an imported module. +unusedStructMember:lib/compat/obstack.c +nullPointerArithmetic:lib/compat/obstack.c + +// Ignore, we are testing the functions. +knownConditionTrueFalse:lib/dpkg/t/t-macros.c + +// Ignore, we use our own test assertions macros. +literalWithCharPtrCompare:lib/dpkg/t/t-test.c + +// Ignore, the code is used only for its binary artifacts. +uninitMemberVar:*/Dpkg_Shlibs/patterns.cpp + +// BUG: False positive. +knownConditionTrueFalse:src/depcon.c:585 +knownConditionTrueFalse:src/depcon.c:668 + +// BUG: False positive, the loop does an early exit. +identicalInnerCondition:lib/dpkg/fsys-hash.c:100 + +// BUG: False positive, this is an enum not a boolean. +redundantCondition:utils/update-alternatives.c:2711 + +// BUG: False positive, the macros from lib/dpkg/dlist.h use the tail member. +unusedStructMember:lib/dpkg/triglib.c:378 + +// BUG: False positive, does not understand must-allocate functions. +nullPointer:src/unpack.c:195 + +// BUG: False positive, does not understand setjmp-style error handling. +redundantAssignment:lib/compat/selinux.c:73 +redundantAssignment:lib/dpkg/t/t-ehandle.c:108 +uninitStructMember:utils/update-alternatives.c:1305 +uninitStructMember:utils/update-alternatives.c:1306 +uninitStructMember:utils/update-alternatives.c:1307 + +// BUG: False positive, does not understand ohshit(), ohshite() and +// bad_format as error terminators. +doubleFree:src/script.c +doubleFree:utils/update-alternatives.c:1213 +va_end_missing:lib/dpkg/parsehelp.c:68 + +// BUG: False positive, the code uses va_copy(). +va_list_usedBeforeStarted:lib/compat/vasprintf.c |